Summary: | [TexMap] Clean up TextureMapperGLData, TextureMapperGLData::SharedGLData | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarcelo, commit-queue, kondapallykalyan, luiz, noam, ossy | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Zan Dobersek
2016-05-03 00:07:30 PDT
Created attachment 277984 [details]
Patch
Attachment 277984 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:161: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 277984 [details] Patch Clearing flags on attachment: 277984 Committed r200407: <http://trac.webkit.org/changeset/200407> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > Comment on attachment 277984 [details] > Patch > > Clearing flags on attachment: 277984 > > Committed r200407: <http://trac.webkit.org/changeset/200407> It made 50+ tests crash on EFL and made the bot early exit: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/27849 (note: I'm not interested in EFL port at all, I just noticed and reported this bug, and cc-ed EFL port maintainers.) (In reply to comment #5) > (In reply to comment #3) > > Comment on attachment 277984 [details] > > Patch > > > > Clearing flags on attachment: 277984 > > > > Committed r200407: <http://trac.webkit.org/changeset/200407> > > It made 50+ tests crash on EFL and made the bot early exit: > https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/ > builds/27849 > > (note: I'm not interested in EFL port at all, I just noticed > and reported this bug, and cc-ed EFL port maintainers.) Should be fixed with r200413. https://trac.webkit.org/r200413 |