Bug 157295

Summary: Web Inspector: Allow format specifiers in console.assert and console.trace
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Assert with Format Strings
none
[IMAGE] Trace with Format Strings none

Joseph Pecoraro
Reported 2016-05-02 20:05:19 PDT
* SUMMARY Allow format specifiers in console.assert and console.trace Identified by the evolving spec: <https://github.com/whatwg/console/issues/4> <https://github.com/whatwg/console/pull/41> * TEST console.assert(false, 'string: %s', 'test'); * ACTUAL Assertion Failed: string: %s – "test" * EXPECTED Assertion failed: string: test
Attachments
[PATCH] Proposed Fix (3.08 KB, patch)
2016-05-02 20:10 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Assert with Format Strings (96.95 KB, image/png)
2016-05-02 20:12 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] Trace with Format Strings (148.77 KB, image/png)
2016-05-02 20:13 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-02 20:06:09 PDT
<rdar://problem/26056039>
Joseph Pecoraro
Comment 2 2016-05-02 20:10:55 PDT
Created attachment 277966 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-05-02 20:12:05 PDT
Created attachment 277967 [details] [IMAGE] Assert with Format Strings
Joseph Pecoraro
Comment 4 2016-05-02 20:13:13 PDT
Created attachment 277968 [details] [IMAGE] Trace with Format Strings
WebKit Commit Bot
Comment 5 2016-05-03 08:23:17 PDT
Comment on attachment 277966 [details] [PATCH] Proposed Fix Clearing flags on attachment: 277966 Committed r200370: <http://trac.webkit.org/changeset/200370>
WebKit Commit Bot
Comment 6 2016-05-03 08:23:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.