Bug 157280

Summary: Web Inspector: Unexpected "Script Element #" resources in Debugger Sidebar
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+
[PATCH] For Landing none

Joseph Pecoraro
Reported 2016-05-02 14:20:12 PDT
* SUMMARY Unexpected "Script Element #" resources in Debugger Sidebar * STEPS TO REPRODUCE 1. Inspect apple.com 2. Reload 3. Show Debugger tab => Unexpected "Script Element 1" and 2 in the sidebar
Attachments
[PATCH] Proposed Fix (1.63 KB, patch)
2016-05-02 14:21 PDT, Joseph Pecoraro
timothy: review+
[PATCH] For Landing (1.66 KB, patch)
2016-05-02 17:19 PDT, Joseph Pecoraro
no flags
Joseph Pecoraro
Comment 1 2016-05-02 14:21:49 PDT
Created attachment 277934 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 2 2016-05-02 15:17:08 PDT
Comment on attachment 277934 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=277934&action=review > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:456 > + if (script.dynamicallyAddedScriptElement) > + return null; Does this need to allow them with a sourceURL?
Joseph Pecoraro
Comment 3 2016-05-02 17:16:37 PDT
(In reply to comment #2) > Comment on attachment 277934 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277934&action=review > > > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:456 > > + if (script.dynamicallyAddedScriptElement) > > + return null; > > Does this need to allow them with a sourceURL? Yes, it probably should!! Good catch.
Joseph Pecoraro
Comment 4 2016-05-02 17:19:29 PDT
Created attachment 277949 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 5 2016-05-02 18:33:57 PDT
Comment on attachment 277949 [details] [PATCH] For Landing Clearing flags on attachment: 277949 Committed r200353: <http://trac.webkit.org/changeset/200353>
Note You need to log in before you can comment on or make changes to this bug.