Bug 157278

Summary: Web Inspector: Prefer "Console Evaluation" to "Eval Code" if we know it was a console evaluation
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Console Evaluation CallFrame in Sidebar none

Joseph Pecoraro
Reported 2016-05-02 14:11:54 PDT
* SUMMARY Prefer "Console Evaluation" to "Eval Code" if we know it was a console evaluation. * STEPS TO REPRODUCE 1. Inspect about:blank 2. Show Debugger Tab 3. Enable break on all exceptions 4. js> throw 'hi' => Sidebar shows "Eval Code", I'd prefer to see "Console Evaluation"
Attachments
[PATCH] Proposed Fix (4.31 KB, patch)
2016-05-02 14:14 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Console Evaluation CallFrame in Sidebar (225.50 KB, image/png)
2016-05-02 14:15 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-02 14:13:32 PDT
<rdar://problem/26048270>
Joseph Pecoraro
Comment 2 2016-05-02 14:14:45 PDT
Created attachment 277931 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-05-02 14:15:07 PDT
Created attachment 277932 [details] [IMAGE] Console Evaluation CallFrame in Sidebar
WebKit Commit Bot
Comment 4 2016-05-02 16:06:46 PDT
Comment on attachment 277931 [details] [PATCH] Proposed Fix Clearing flags on attachment: 277931 Committed r200345: <http://trac.webkit.org/changeset/200345>
WebKit Commit Bot
Comment 5 2016-05-02 16:06:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.