Bug 157271

Summary: Add to the Animations log channel output about which properties are being blended
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dino: review+
For EWS none

Simon Fraser (smfr)
Reported 2016-05-02 11:59:29 PDT
Add to the Animations log channel output about which properties are being blended
Attachments
Patch (35.62 KB, patch)
2016-05-02 12:01 PDT, Simon Fraser (smfr) 		dino: review+
DetailsFormatted DiffDiff
For EWS (41.11 KB, patch)
2016-05-02 12:48 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-05-02 12:01:38 PDT
Created attachment 277920 [details] Patch
WebKit Commit Bot
Comment 2 2016-05-02 12:02:36 PDT
Attachment 277920 [details] did not pass style-queue: ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:428: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:740: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:865: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:907: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1084: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1130: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1169: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1238: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 8 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 3 2016-05-02 12:08:08 PDT
Comment on attachment 277920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277920&action=review > Source/WebCore/CMakeLists.txt:2112 > + platform/LengthBox.cpp I think you forgot to include this file in your patch. > Source/WebCore/CMakeLists.txt:2286 > + platform/graphics/transforms/TransformOperation.cpp And this one too.
Simon Fraser (smfr)
Comment 4 2016-05-02 12:48:20 PDT
Created attachment 277924 [details] For EWS
WebKit Commit Bot
Comment 5 2016-05-02 12:50:53 PDT
Attachment 277924 [details] did not pass style-queue: ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:428: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:740: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:865: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:907: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1084: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1130: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1169: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1238: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 8 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 6 2016-05-02 15:20:59 PDT
https://trac.webkit.org/r200341
Note You need to log in before you can comment on or make changes to this bug.