| Summary: | Add to the Animations log channel output about which properties are being blended | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2016-05-02 11:59:29 PDT
Created attachment 277920 [details]
Patch
Attachment 277920 [details] did not pass style-queue:
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:428: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:740: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:865: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:907: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1084: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1130: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1169: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1238: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 8 in 28 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 277920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277920&action=review > Source/WebCore/CMakeLists.txt:2112 > + platform/LengthBox.cpp I think you forgot to include this file in your patch. > Source/WebCore/CMakeLists.txt:2286 > + platform/graphics/transforms/TransformOperation.cpp And this one too. Created attachment 277924 [details]
For EWS
Attachment 277924 [details] did not pass style-queue:
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:428: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:740: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:865: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:907: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1084: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1130: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1169: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1238: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 8 in 30 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|