Bug 157245

Summary: document.currentScript must be null when we're executing a script inside a shadow tree
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Fixes the bug
none
Removed commented out code
none
Archive of layout-test-results from ews114 for mac-yosemite
none
Fixed one more issue
none
Fixed the variable name darin: review+

Description Ryosuke Niwa 2016-05-01 00:04:26 PDT
Otherwise it exposes a node inside a shadow tree to the outside.
Comment 1 Ryosuke Niwa 2016-05-01 23:31:39 PDT
Created attachment 277894 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2016-05-01 23:32:29 PDT
Created attachment 277895 [details]
Removed commented out code
Comment 3 Ryosuke Niwa 2016-05-02 00:29:31 PDT
Comment on attachment 277895 [details]
Removed commented out code

Thanks for the review!
Comment 4 Build Bot 2016-05-02 00:41:26 PDT
Comment on attachment 277895 [details]
Removed commented out code

Attachment 277895 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1254359

New failing tests:
http/tests/misc/async-script.html
http/tests/misc/async-script-removed.html
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_010.htm
Comment 5 Build Bot 2016-05-02 00:41:31 PDT
Created attachment 277896 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Ryosuke Niwa 2016-05-02 01:59:42 PDT
The assertion I added is failing due to a spec bug.  Filed https://github.com/whatwg/html/issues/1161 and implemented the proposed solution.
Comment 7 Ryosuke Niwa 2016-05-02 01:59:50 PDT
Created attachment 277898 [details]
Fixed one more issue
Comment 8 Ryosuke Niwa 2016-05-02 02:02:29 PDT
Created attachment 277899 [details]
Fixed the variable name
Comment 9 Ryosuke Niwa 2016-05-02 11:19:07 PDT
Committed r200327: <http://trac.webkit.org/changeset/200327>
Comment 10 Ryosuke Niwa 2016-05-02 12:09:40 PDT
<rdar://problem/26045378>