Bug 157242

Summary: Use enum class instead of string-based enums in RTC code
Product: WebKit Reporter: Darin Adler <darin>
Component: BindingsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2016-04-30 22:19:32 PDT
Use enum class instead of string-based enums in RTC code
Attachments
Patch (6.76 KB, patch)
2016-04-30 22:22 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (6.76 KB, patch)
2016-04-30 22:34 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-04-30 22:22:09 PDT
Created attachment 277843 [details] Patch
Darin Adler
Comment 2 2016-04-30 22:34:27 PDT
Created attachment 277845 [details] Patch
Alex Christensen
Comment 3 2016-04-30 22:46:29 PDT
Comment on attachment 277845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277845&action=review > Source/WebCore/ChangeLog:19 > + * Modules/mediastream/RTCConfiguration.idl: Updated the names and values of the > + enums to match the current RTC specification. Again, as I said, this should be Yep, https://github.com/w3c/webrtc-pc/pull/432/files
WebKit Commit Bot
Comment 4 2016-05-01 09:36:31 PDT
Comment on attachment 277845 [details] Patch Clearing flags on attachment: 277845 Committed r200304: <http://trac.webkit.org/changeset/200304>
WebKit Commit Bot
Comment 5 2016-05-01 09:36:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.