Bug 157230 – Some content causes deep recursion.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

Created attachment 277795 [details]
Test case

See attached test case.

[alan]

rdar://problem/7694756

[alan]

Created attachment 277796 [details]
WIP patch

This patch limits render tree nesting. DOM can have all the nested nodes but renderer tree has only up to 512. (from 512 and up, it's like they were display: none}
This (DOM vs render tree) matches FF(45.0.2) behavior.

[Alexey Proskuryakov]

> This (DOM vs render tree) matches FF(45.0.2) behavior.

But not Chrome?

[alan]

(In reply to comment #3)
> > This (DOM vs render tree) matches FF(45.0.2) behavior.
> 
> But not Chrome?
No, Chrome crashes when the stack space is exhausted.

[alan]

Created attachment 277839 [details]
Patch

[Antti Koivisto]

Comment on attachment 277839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277839&action=review

> Source/WebCore/style/StyleTreeResolver.cpp:370
>          auto& element = downcast<Element>(node);
> +        if (it.depth() > Settings::defaultMaximumRenderTreeDepth) {

An empty line after auto& element would look nicer.

[alan]

Created attachment 277840 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 277840 [details]
Patch

Clearing flags on attachment: 277840

Committed r200301: <http://trac.webkit.org/changeset/200301>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.