Bug 157219

Summary: AX: @aria-label attribute should work on <label> element
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
initial patch
none
patch none

Nan Wang
Reported 2016-04-29 17:50:24 PDT
In case: <label for="txtBox1" aria-label="Enter date in format MM/DD/YY">Date:</label> <input id="txtBox1" /> I would expect the value specified in the aria-label attribute to supersede the actual value of the label. I.e. I would expect VoiceOver to announce "Enter date in format MM/DD/YY". Instead the base value is announced ("Date"). <rdar://problem/15199588>
Attachments
initial patch (5.89 KB, patch)
2016-04-29 17:57 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (5.82 KB, patch)
2016-04-30 00:14 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nan Wang
Comment 1 2016-04-29 17:57:33 PDT
Created attachment 277769 [details] initial patch
chris fleizach
Comment 2 2016-04-29 18:03:22 PDT
Comment on attachment 277769 [details] initial patch View in context: https://bugs.webkit.org/attachment.cgi?id=277769&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1269 > + // If there's aria-label on the label, we should use it instead. this comment seems unnecessary, since its self evident from the code > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1270 > + const AtomicString& labelStr = labelObject->getAttribute(aria_labelAttr); const AtomicString& ariaLabel > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1075 > + // otherwise its inner text will be announced by screenreader. announced by "a" screenrea
Nan Wang
Comment 3 2016-04-30 00:14:53 PDT
Created attachment 277799 [details] patch applied review comments
WebKit Commit Bot
Comment 4 2016-04-30 11:06:16 PDT
Comment on attachment 277799 [details] patch Clearing flags on attachment: 277799 Committed r200290: <http://trac.webkit.org/changeset/200290>
WebKit Commit Bot
Comment 5 2016-04-30 11:06:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.