Bug 157217

Summary: [JSC][ARMv7S] Arithmetic module results change when tiering up to DFG
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2016-04-29 16:58:37 PDT
[JSC][ARMv7S] Arithmetic module results change when tiering up to DFG
Attachments
Patch (6.04 KB, patch)
2016-04-29 17:07 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-04-29 17:07:34 PDT
Created attachment 277761 [details] Patch
Mark Lam
Comment 2 2016-04-29 18:04:52 PDT
Comment on attachment 277761 [details] Patch r=me. I see that the op_mod.js test will test combinations of positive and negative numbers of interesting sizes. I trust that if this patch passes the op_mod.js test on ARMv7s, then your decision of when to use the integer math and when to defer to fmod is correct.
WebKit Commit Bot
Comment 3 2016-04-29 18:50:11 PDT
Comment on attachment 277761 [details] Patch Clearing flags on attachment: 277761 Committed r200277: <http://trac.webkit.org/changeset/200277>
WebKit Commit Bot
Comment 4 2016-04-29 18:50:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.