Bug 157211

Summary: Node.nodeName should not be nullable
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-node
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-04-29 16:03:24 PDT
Node.nodeName should not be nullable as per the specification: https://dom.spec.whatwg.org/#interface-node Our implementation never returns null anyway. However, having it as nullable in the IDL means we use jsStringOrNull() instead of jsStringWithCache(), thus doing an unnecessary null check.
Attachments
Patch (1.57 KB, patch)
2016-04-29 16:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-04-29 16:08:28 PDT
Created attachment 277748 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-29 17:12:04 PDT
Comment on attachment 277748 [details] Patch Clearing flags on attachment: 277748 Committed r200271: <http://trac.webkit.org/changeset/200271>
WebKit Commit Bot
Comment 3 2016-04-29 17:12:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.