Bug 157204

Summary: Drop useless check in SpeculativeLoadManager::registerLoad()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+, koivisto: commit-queue-

Description Chris Dumez 2016-04-29 14:54:55 PDT
Drop useless check in SpeculativeLoadManager::registerLoad()
Comment 1 Chris Dumez 2016-04-29 15:03:15 PDT
Created attachment 277734 [details]
Patch
Comment 2 Antti Koivisto 2016-04-29 20:29:40 PDT
Comment on attachment 277734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277734&action=review

> Source/WebKit2/ChangeLog:14
> +2016-04-29  Chris Dumez  <cdumez@apple.com>
> +
> +        Drop useless check in SpeculativeLoadManager::registerLoad()
> +        https://bugs.webkit.org/show_bug.cgi?id=157204
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Drop useless check in SpeculativeLoadManager::registerLoad(). There is
> +        no way to end up this code path with a non-HTTP family request.
> +
> +        * NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
> +        (WebKit::NetworkCache::SpeculativeLoadManager::registerLoad):
> +
> +2016-04-29  Chris Dumez  <cdumez@apple.com>

ChangeLog repeats
Comment 3 Chris Dumez 2016-04-29 20:36:18 PDT
Committed r200281: <http://trac.webkit.org/changeset/200281>