Bug 157177

Summary: Limit ResourceTiming to WEB_TIMING enabled builds
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: achristensen, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+

Description Yoav Weiss 2016-04-29 05:44:31 PDT 
Limit ResourceTiming to WEB_TIMING enabled builds
Comment 1 Yoav Weiss 2016-04-29 05:47:50 PDT 
Created attachment 277694 [details]
Patch
Comment 2 Yoav Weiss 2016-04-29 05:50:44 PDT 
When looking into why https://bugs.webkit.org/show_bug.cgi?id=157133 broke the Mac cmake build, I saw that the build breaks when WEB_TIMING is not enabled (which is the case for the Mac cmake build).

This corrects such builds. As a next step, I also intend to turn on WEB_TIMING on the Mac cmake build by default.
Comment 3 Alex Christensen 2016-04-29 10:04:06 PDT 
Comment on attachment 277694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277694&action=review

> Source/WebCore/page/PerformanceResourceTiming.h:88
> +#endif // !ENABLE(WEB_TIMING)

no !
Comment 4 Yoav Weiss 2016-04-29 12:21:48 PDT 
Since https://bugs.webkit.org/show_bug.cgi?id=157133 got reverted, this patch can no longer be applied. I'll merge it into the one in 157133

*** This bug has been marked as a duplicate of bug 157133 ***