Bug 157156

Summary:

Remove unused bool parameter in CodeCache::getGlobalCodeBlock

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

JavaScriptCore

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gskachkov, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2016-04-28 16:46:26 PDT

* SUMMARY Remove unused bool parameter in CodeCache::getGlobalCodeBlock. Seems this was intended to be "isArrowFunctionContext" for CodeCache::getEvalCodeBlock, but CodeCache::getGlobalCodeBlock just checks the executable->isArrowFunctionContext, so the boolean parameter was never named or used since it was added. Just remove it.

Attachments
[PATCH] Proposed Fix (10.52 KB, patch) 2016-04-28 16:56 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-04-28 16:56:24 PDT

Created attachment 277665 [details] [PATCH] Proposed Fix

Mark Lam

Comment 2 2016-04-28 17:02:31 PDT

Comment on attachment 277665 [details] [PATCH] Proposed Fix r=me

WebKit Commit Bot

Comment 3 2016-04-28 17:53:01 PDT

Comment on attachment 277665 [details] [PATCH] Proposed Fix Clearing flags on attachment: 277665 Committed r200218: <http://trac.webkit.org/changeset/200218>

WebKit Commit Bot

Comment 4 2016-04-28 17:53:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.