Bug 157139

Summary: [JSC] implement spec changes for String#padStart and String#padEnd
Product: WebKit Reporter: Caitlin Potter (:caitp) <caitp>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, fpizlo, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Caitlin Potter (:caitp)
Reported 2016-04-28 09:06:29 PDT
[JSC] implement spec changes for String#padStart and String#padEnd
Attachments
Patch (5.27 KB, patch)
2016-04-28 09:08 PDT, Caitlin Potter (:caitp) 		no flags
DetailsFormatted DiffDiff
Patch (5.26 KB, patch)
2016-04-28 09:12 PDT, Caitlin Potter (:caitp) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Caitlin Potter (:caitp)
Comment 1 2016-04-28 09:08:00 PDT
Created attachment 277625 [details] Patch A followup to move this implementation to self-hosted JS will follow
WebKit Commit Bot
Comment 2 2016-04-28 09:10:21 PDT
Attachment 277625 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Caitlin Potter (:caitp)
Comment 3 2016-04-28 09:12:53 PDT
Created attachment 277626 [details] Patch ...and make check-webkit-style happy
Keith Miller
Comment 4 2016-04-28 09:45:56 PDT
Comment on attachment 277626 [details] Patch r=me
WebKit Commit Bot
Comment 5 2016-04-28 10:04:49 PDT
Comment on attachment 277626 [details] Patch Clearing flags on attachment: 277626 Committed r200194: <http://trac.webkit.org/changeset/200194>
WebKit Commit Bot
Comment 6 2016-04-28 10:04:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.