Bug 157129

Summary: [css-grid] Fix typo in CSS class for layout tests
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, lforschler, rego, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2016-04-28 04:43:55 PDT
[css-grid] Fix typo in CSS class for layout tests
Attachments
Patch (1.43 KB, patch)
2016-04-28 04:44 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-04-28 04:44:31 PDT
Created attachment 277610 [details] Patch
Sergio Villar Senin
Comment 2 2016-04-28 05:07:46 PDT
Comment on attachment 277610 [details] Patch What about removing it?
Manuel Rego Casasnovas
Comment 3 2016-04-28 06:13:31 PDT
Thanks for the review. (In reply to comment #2) > Comment on attachment 277610 [details] > Patch > > What about removing it? The class is called "secondRowFourthColumn", so I prefer to keep it. So if it's used in a future test (with less items) it'd work properly. Other option would be to change what's used in those tests for something like "autoRowFourthColumn", but I think it doesn't worth it.
WebKit Commit Bot
Comment 4 2016-04-28 07:01:34 PDT
Comment on attachment 277610 [details] Patch Clearing flags on attachment: 277610 Committed r200189: <http://trac.webkit.org/changeset/200189>
WebKit Commit Bot
Comment 5 2016-04-28 07:01:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.