Bug 157129

Summary:

[css-grid] Fix typo in CSS class for layout tests

Product:

WebKit

Reporter:

Manuel Rego Casasnovas <rego>

Component:

Tools / Tests

Assignee:

Manuel Rego Casasnovas <rego>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jfernandez, lforschler, rego, svillar

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

60731

Attachments:

Description	Flags
Patch	none

Description Manuel Rego Casasnovas 2016-04-28 04:43:55 PDT

[css-grid] Fix typo in CSS class for layout tests

Comment 1 Manuel Rego Casasnovas 2016-04-28 04:44:31 PDT

Created attachment 277610 [details]
Patch

Comment 2 Sergio Villar Senin 2016-04-28 05:07:46 PDT

Comment on attachment 277610 [details]
Patch

What about removing it?

Comment 3 Manuel Rego Casasnovas 2016-04-28 06:13:31 PDT

Thanks for the review.

(In reply to comment #2)
> Comment on attachment 277610 [details]
> Patch
> 
> What about removing it?

The class is called "secondRowFourthColumn", so I prefer to keep it.
So if it's used in a future test (with less items) it'd work properly.

Other option would be to change what's used in those tests for something like "autoRowFourthColumn", but I think it doesn't worth it.

Comment 4 WebKit Commit Bot 2016-04-28 07:01:34 PDT

Comment on attachment 277610 [details]
Patch

Clearing flags on attachment: 277610

Committed r200189: <http://trac.webkit.org/changeset/200189>

Comment 5 WebKit Commit Bot 2016-04-28 07:01:38 PDT

All reviewed patches have been landed.  Closing bug.