Bug 157112 – RTL non-native <select> buttons should have arrows on the left

• Component: New Bugs
• Status: RESOLVED FIXED

[Dean Jackson]

RTL non-native <select> buttons should have arrows on the left

[Dean Jackson]

<rdar://problem/25894441>

[Dean Jackson]

Created attachment 277563 [details]
Patch

[Jon Lee]

Comment on attachment 277563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277563&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:1334
> +        leftEdgeOfSeparator = static_cast<int>(roundf(leftEdge - arrowPaddingBefore * renderer.style().effectiveZoom()));

roundf() even with retina?

[Dean Jackson]

Comment on attachment 277563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277563&action=review

>> Source/WebCore/rendering/RenderThemeMac.mm:1334
>> +        leftEdgeOfSeparator = static_cast<int>(roundf(leftEdge - arrowPaddingBefore * renderer.style().effectiveZoom()));
> 
> roundf() even with retina?

Previously it was just the cast to int, so I guess this might be slightly different on retina.

I'll open a bug to properly retina-fy this whole thing. We should use floats everywhere.

[Dean Jackson]

Committed r200165: <http://trac.webkit.org/changeset/200165>

[Ryan Haddad]

Added an ios-simulator expectation for the LayoutTest added with this change in <http://trac.webkit.org/projects/webkit/changeset/200207>