| Summary: | [iOS WK2] When determining tile size, check whether ancestor UIScrollViews are actually scrollable | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, sabouhallawa, simon.fraser, thorton | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2016-04-27 16:39:06 PDT
Created attachment 277547 [details]
Patch
Attachment 277547 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:60: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 277547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277547&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1956 > ++ (BOOL)scrollViewCanScroll:(UIScrollView *)scrollView why is this not just a static C function? Reverted r199259 and r200161 for reason: Seems to have caused a ~1.2% PLT regression on iOS Committed r200390: <http://trac.webkit.org/changeset/200390> This got re-landed in http://trac.webkit.org/r200470 |