Bug 157102

Summary: Remove download message receiver when NetworkProcess crashes
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Alex Christensen 2016-04-27 14:25:55 PDT
Remove download message receiver when NetworkProcess crashes
Comment 1 Alex Christensen 2016-04-27 14:29:46 PDT
Created attachment 277534 [details]
Patch
Comment 2 Anders Carlsson 2016-04-27 14:34:23 PDT
Comment on attachment 277534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277534&action=review

> Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.cpp:75
> +    for (auto it = m_downloads.begin(), end = m_downloads.end(); it != end; ++it) {
> +        it->value->processDidClose();
> +        it->value->invalidate();
> +        m_process->removeMessageReceiver(Messages::DownloadProxy::messageReceiverName(), it->key.downloadID());
>      }

You can get the a download ID from the download itself, no need to iterate both the keys and the values. Also, please use a modern for loop.
Comment 3 Alex Christensen 2016-04-27 14:39:31 PDT
http://trac.webkit.org/changeset/200152