Bug 15710

Summary: When QD plugins draw to an offscreen bitmap and the plugin is not at (0, 0) the clipping rectangle is not correct
Product: WebKit Reporter: Mark Ambachtsheer <mark.a>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.5   
URL: http://gmodules.com/ig/creator?synd=open&url=http%3A//bejeweledg.googlecode.com/svn/trunk/bejeweled.xml&pt=%26context%3Dd%26synd%3Dopen%26lang%3Den%26.lang%3Den%26country%3Dus%26.country%3Dus%26cat%3Dall%26num%3D1%26start%3D-1%26cols%3D1%26objs%3D0sN&sn=0sN&lang=en
Attachments:
Description Flags
Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds. darin: review+

Mark Ambachtsheer
Reported 2007-10-26 08:54:38 PDT
The code to render QD plugins on offscreen GWorlds does not account for the position of the plugin when calculating the clipping rectangle for the QD window. This is apparent when using a Google Gadget like Bejeweled (URL attached) in an application that uses a WebKit view with an offscreen GWorld (i.e. not Safari). This was not previously noticed because many widgets/gadgets/Flash videos place the plugin content at (0,0); Google Gadgets on the other hand place a text label above the plugin.
Attachments
Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds. (1.58 KB, patch)
2007-10-26 09:01 PDT, Mark Ambachtsheer 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Ambachtsheer
Comment 1 2007-10-26 09:01:21 PDT
Created attachment 16880 [details] Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds. This is a one-line change that should affect only applications that render to an offscreen GWorld (i.e. not Safari).
Darin Adler
Comment 2 2007-10-26 09:25:25 PDT
Comment on attachment 16880 [details] Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds. Looks fine, and I'm assuming you tested it in your project. r=me
Mark Rowe (bdash)
Comment 3 2007-10-27 03:57:37 PDT
Landed in r27148.
Note You need to log in before you can comment on or make changes to this bug.