Bug 157096

Summary: Address feedback from https://bugs.webkit.org/show_bug.cgi?id=157048#c5.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, keith_miller, mitz, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ggaren: review+

Mark Lam
Reported 2016-04-27 11:48:35 PDT
In JSWrapperMap.mm, 1. Check for USE(APPLE_INTERNAL_SDK) instead of __has_include(<mach-o/dyld_priv.h>). 2. Rename webkitFirstSDKVersionWithInitConstructorSupport to firstSDKVersionWithInitConstructorSupport.
Attachments
proposed patch. (2.12 KB, patch)
2016-04-27 11:55 PDT, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-04-27 11:55:43 PDT
Created attachment 277523 [details] proposed patch.
Geoffrey Garen
Comment 2 2016-04-27 11:56:47 PDT
Comment on attachment 277523 [details] proposed patch. r=me
Mark Lam
Comment 3 2016-04-27 12:03:55 PDT
Thanks for the review. Landed in r200139: <http://trac.webkit.org/r200139>.
Note You need to log in before you can comment on or make changes to this bug.