Bug 157090

Summary: Remove unnecessary HashMap from Font
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch for committing none

Myles C. Maxfield
Reported 2016-04-27 10:44:05 PDT
Remove unnecessary HashMap from Font
Attachments
Patch (2.76 KB, patch)
2016-04-27 10:45 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
Patch for committing (2.73 KB, patch)
2016-04-27 11:08 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-04-27 10:45:41 PDT
Created attachment 277488 [details] Patch
Darin Adler
Comment 2 2016-04-27 10:57:57 PDT
Comment on attachment 277488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277488&action=review > Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:40 > + RetainPtr<CFDictionaryRef>& attributesDictionary = enableKerning ? m_kernedCFStringAttributes : m_nonKernedCFStringAttributes; I think auto& would be better here.
Myles C. Maxfield
Comment 3 2016-04-27 11:08:08 PDT
Created attachment 277493 [details] Patch for committing
WebKit Commit Bot
Comment 4 2016-04-27 12:00:09 PDT
Comment on attachment 277493 [details] Patch for committing Clearing flags on attachment: 277493 Committed r200140: <http://trac.webkit.org/changeset/200140>
Ahmad Saleem
Comment 5 2022-10-10 14:34:47 PDT
Landed - https://github.com/WebKit/WebKit/commit/dc94eba5215171e6b1a53ee15b619a0d6143cfcd and didn't back out. Marking this as "RESOLVED FIXED".
Radar WebKit Bug Importer
Comment 6 2022-10-10 14:35:17 PDT
<rdar://problem/100997848>
Note You need to log in before you can comment on or make changes to this bug.