Bug 157057

Summary: Support legacy HTTP headers in WebSockets
Product: WebKit Reporter: John Wilander <wilander>
Component: WebCore Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 155602    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description John Wilander 2016-04-26 18:02:00 PDT 
The following four HTTP headers are needed for legacy reasons:
Sec-WebSocket-Location
Sec-WebSocket-Origin
WebSocket-Location
WebSocket-Origin
Comment 1 John Wilander 2016-04-26 18:03:11 PDT 
rdar://problem/25913345
Comment 2 John Wilander 2016-04-26 18:39:11 PDT 
Created attachment 277432 [details]
Patch
Comment 3 Brent Fulgham 2016-04-26 19:32:47 PDT 
r=me
Comment 4 Alexey Proskuryakov 2016-04-26 19:59:34 PDT 
Comment on attachment 277432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277432&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests since these headers are not officially supported and should not be used.

This is not a reason to avoid tests. If they were worth adding, it's worth verifying that we don't accidentally break them.
Comment 5 WebKit Commit Bot 2016-04-26 20:21:33 PDT 
Comment on attachment 277432 [details]
Patch

Clearing flags on attachment: 277432

Committed r200120: <http://trac.webkit.org/changeset/200120>
Comment 6 WebKit Commit Bot 2016-04-26 20:21:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 John Wilander 2016-04-27 11:51:49 PDT 
Bug for adding test cases: https://bugs.webkit.org/show_bug.cgi?id=157095