Bug 157046

Summary:

[JSC] GetByVal on Undecided use its children before its OSR Exit

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, ossy, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2016-04-26 15:26:22 PDT

[JSC] GetByVal on Undecided use its children before its OSR Exit

Comment 1 Benjamin Poulain 2016-04-26 15:30:40 PDT

Created attachment 277413 [details]
Patch

Comment 2 Mark Lam 2016-04-26 15:33:48 PDT

Comment on attachment 277413 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2016-04-26 16:25:53 PDT

Comment on attachment 277413 [details]
Patch

Clearing flags on attachment: 277413

Committed r200113: <http://trac.webkit.org/changeset/200113>

Comment 4 WebKit Commit Bot 2016-04-26 16:25:58 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Csaba Osztrogonác 2016-04-27 01:40:20 PDT

(In reply to comment #3)
> Comment on attachment 277413 [details]
> Patch
> 
> Clearing flags on attachment: 277413
> 
> Committed r200113: <http://trac.webkit.org/changeset/200113>

The new test introduced in this change fails on all 32 bit platforms:
- https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/2205
- https://build.webkit.org/builders/Apple%20Yosemite%2032-bit%20JSC%20%28BuildAndTest%29/builds/8925
- https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/60882
- https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/390

Comment 6 Benjamin Poulain 2016-04-27 10:46:54 PDT

(In reply to comment #5)
> (In reply to comment #3)
> > Comment on attachment 277413 [details]
> > Patch
> > 
> > Clearing flags on attachment: 277413
> > 
> > Committed r200113: <http://trac.webkit.org/changeset/200113>
> 
> The new test introduced in this change fails on all 32 bit platforms:
> -
> https://build.webkit.org/builders/Apple%20El%20Capitan%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/2205
> -
> https://build.webkit.org/builders/Apple%20Yosemite%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/8925
> -
> https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/60882
> -
> https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/
> builds/390

Oh! Looks like I forgot to fix the 32bit counterpart. I'll do that today.

Comment 7 Benjamin Poulain 2016-04-27 10:58:33 PDT

Quick follow up for 32bit: http://trac.webkit.org/changeset/200133
Thanks Ossy.