Bug 157043

Summary: [Web IDL] Specify default values for optional parameters of type 'unsigned long'
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-04-26 14:20:40 PDT
Specify default values for optional parameters of type 'unsigned long' and let the bindings generator use WTF::Optional<> for the parameters that do not have such default value.
Attachments
Patch (10.39 KB, patch)
2016-04-26 15:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-04-26 15:17:55 PDT
Created attachment 277411 [details] Patch
Chris Dumez
Comment 2 2016-04-26 15:53:26 PDT
Comment on attachment 277411 [details] Patch Clearing flags on attachment: 277411 Committed r200110: <http://trac.webkit.org/changeset/200110>
Chris Dumez
Comment 3 2016-04-26 15:53:32 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 4 2016-05-17 10:07:48 PDT
Interestingly, this was a confirmed 1.5% PLT progression on iOS.
Darin Adler
Comment 5 2016-05-19 12:46:51 PDT
Which change do you think was responsible?
Note You need to log in before you can comment on or make changes to this bug.