Bug 157038

Summary:

Check to make sure shouldRequestCandidates() before requesting candidates

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, thorton

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Beth Dakin

Reported 2016-04-26 11:52:30 PDT

Check to make sure shouldRequestCandidates() before requesting candidates

Attachments
Patch (9.95 KB, patch) 2016-04-26 11:57 PDT, Beth Dakin	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2016-04-26 11:57:21 PDT

Created attachment 277403 [details] Patch

WebKit Commit Bot

Comment 2 2016-04-26 11:59:52 PDT

Attachment 277403 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2172: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1164: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Beth Dakin

Comment 3 2016-04-26 13:09:26 PDT

Thanks Tim! http://trac.webkit.org/changeset/200106

Note You need to log in before you can comment on or make changes to this bug.