Summary: | Check to make sure shouldRequestCandidates() before requesting candidates | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, commit-queue, thorton | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Beth Dakin
2016-04-26 11:52:30 PDT
Created attachment 277403 [details]
Patch
Attachment 277403 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2172: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1164: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thanks Tim! http://trac.webkit.org/changeset/200106 |