Bug 157026

Summary: Update tests in web-platform-tests/html/semantics/scripting-1/
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143519    
Attachments:
Description Flags
Reimported tests darin: review+

Ryosuke Niwa
Reported 2016-04-25 23:08:07 PDT
Update tests.
Attachments
Reimported tests (98.62 KB, patch)
2016-04-25 23:09 PDT, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-04-25 23:09:55 PDT
Created attachment 277340 [details] Reimported tests
Darin Adler
Comment 2 2016-04-26 09:03:01 PDT
Comment on attachment 277340 [details] Reimported tests View in context: https://bugs.webkit.org/attachment.cgi?id=277340&action=review > LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_001.htm:10 > + <script src="/resources/testharness.js"></script> > + <script src="/resources/testharnessreport.js"></script> Can we make our import script rewrite these so they use paths relative to the test rather than from the top level of the website? That way we can use these tests from file URLs, not just with the test web server running.
Darin Adler
Comment 3 2016-04-26 09:03:20 PDT
Comment on attachment 277340 [details] Reimported tests View in context: https://bugs.webkit.org/attachment.cgi?id=277340&action=review > LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/w3c-import.log:7 > Then run the Tools/Scripts/import-w3c-tests in Webkit to reimport Second misspelled WebKit. You fixed one but not the other.
Ryosuke Niwa
Comment 4 2016-04-26 15:53:29 PDT
(In reply to comment #2) > Comment on attachment 277340 [details] > Reimported tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277340&action=review > > > LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_001.htm:10 > > + <script src="/resources/testharness.js"></script> > > + <script src="/resources/testharnessreport.js"></script> > > Can we make our import script rewrite these so they use paths relative to > the test rather than from the top level of the website? That way we can use > these tests from file URLs, not just with the test web server running. That would be tricky because the script doesn't know where testharness.js is located relative to each test.
Ryosuke Niwa
Comment 5 2016-04-26 16:02:45 PDT
Committed r200111: <http://trac.webkit.org/changeset/200111>
Note You need to log in before you can comment on or make changes to this bug.