Bug 157025

Summary: DFG backends shouldn't emit type checks at KnownBlah edges
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
possible patch
none
the patch msaboff: review+

Description Filip Pizlo 2016-04-25 22:42:38 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-04-25 22:44:16 PDT 
Created attachment 277338 [details]
possible patch
Comment 2 WebKit Commit Bot 2016-04-25 22:45:28 PDT 
Attachment 277338 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:102:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:123:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-04-26 09:44:11 PDT 
Created attachment 277390 [details]
the patch
Comment 4 WebKit Commit Bot 2016-04-26 09:45:39 PDT 
Attachment 277390 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:102:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:123:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Michael Saboff 2016-04-26 10:19:26 PDT 
Comment on attachment 277390 [details]
the patch

r=me
Comment 6 Filip Pizlo 2016-04-26 11:03:08 PDT 
Landed in http://trac.webkit.org/changeset/200096