Bug 157025 - DFG backends shouldn't emit type checks at KnownBlah edges
Summary: DFG backends shouldn't emit type checks at KnownBlah edges
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-25 22:42 PDT by Filip Pizlo
Modified: 2016-04-26 11:03 PDT (History)
5 users (show)

See Also:

Attachments
possible patch (4.57 KB, patch)
2016-04-25 22:44 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (9.24 KB, patch)
2016-04-26 09:44 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-04-25 22:42:38 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-04-25 22:44:16 PDT 
Created attachment 277338 [details]
possible patch
Comment 2 WebKit Commit Bot 2016-04-25 22:45:28 PDT 
Attachment 277338 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:102:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:123:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-04-26 09:44:11 PDT 
Created attachment 277390 [details]
the patch
Comment 4 WebKit Commit Bot 2016-04-26 09:45:39 PDT 
Attachment 277390 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:102:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:123:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Michael Saboff 2016-04-26 10:19:26 PDT 
Comment on attachment 277390 [details]
the patch

r=me
Comment 6 Filip Pizlo 2016-04-26 11:03:08 PDT 
Landed in http://trac.webkit.org/changeset/200096