Bug 157018

Summary:

Web Inspector: Clarify Heap Snapshot instance Retained Size by hiding retained size of non-dominated children

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[IMAGE] Before - Show Retained Size for all	none
[IMAGE] Partial - Show Retained Size for immediately dominated children	none
[IMAGE] After - Show Retained Size for immediately dominated and transitively dominated children	none

Joseph Pecoraro

Reported 2016-04-25 20:29:57 PDT

* SUMMARY Clarify Heap Snapshot instance Retained Size by hiding retained size of non-dominated children It can be confusing to expand a Heap Snapshot Instance and see a larger number than the retained size of the instance itself. That is because this is just a reference to another instance, but it is not dominated by the base object being expanded. Clarify this by only showing retained size of children that are dominated by the base object, and hiding the retained size of children that are not dominated.

Attachments
[PATCH] Proposed Fix (9.48 KB, patch) 2016-04-25 20:33 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[IMAGE] Before - Show Retained Size for all (220.33 KB, image/png) 2016-04-25 20:33 PDT, Joseph Pecoraro	no flags	Details
[IMAGE] Partial - Show Retained Size for immediately dominated children (209.80 KB, image/png) 2016-04-25 20:34 PDT, Joseph Pecoraro	no flags	Details
[IMAGE] After - Show Retained Size for immediately dominated and transitively dominated children (219.52 KB, image/png) 2016-04-25 20:34 PDT, Joseph Pecoraro	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-04-25 20:31:42 PDT

<rdar://problem/25923913>

Joseph Pecoraro

Comment 2 2016-04-25 20:33:26 PDT

Created attachment 277314 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 3 2016-04-25 20:33:56 PDT

Created attachment 277316 [details] [IMAGE] Before - Show Retained Size for all

Joseph Pecoraro

Comment 4 2016-04-25 20:34:23 PDT

Created attachment 277317 [details] [IMAGE] Partial - Show Retained Size for immediately dominated children

Joseph Pecoraro

Comment 5 2016-04-25 20:34:54 PDT

Created attachment 277318 [details] [IMAGE] After - Show Retained Size for immediately dominated and transitively dominated children

WebKit Commit Bot

Comment 6 2016-04-26 08:03:11 PDT

Comment on attachment 277314 [details] [PATCH] Proposed Fix Clearing flags on attachment: 277314 Committed r200086: <http://trac.webkit.org/changeset/200086>

WebKit Commit Bot

Comment 7 2016-04-26 08:03:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.