Bug 156987

Summary: AX: Crash at -[WebAccessibilityObjectWrapper accessibilityAttributeValue:] + 4391
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Initial patch
none
patch none

Description Nan Wang 2016-04-25 12:13:30 PDT 
Crash when asking for the slider indicator's value if the parent slider is null.

<rdar://problem/25881658>
Comment 1 Nan Wang 2016-04-25 12:21:34 PDT 
Created attachment 277266 [details]
Initial patch
Comment 2 chris fleizach 2016-04-25 13:43:50 PDT 
Comment on attachment 277266 [details]
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277266&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2751
> +            return !m_object->parentObject() ? nullptr : [NSNumber numberWithFloat:m_object->parentObject()->valueForRange()];

can we instead check earlier than this if the object is detachedFromParent() 
then that will take care of this and other cases
Comment 3 Nan Wang 2016-04-25 13:55:40 PDT 
Created attachment 277276 [details]
patch

review comments.
Comment 4 WebKit Commit Bot 2016-04-25 15:40:19 PDT 
Comment on attachment 277276 [details]
patch

Clearing flags on attachment: 277276

Committed r200054: <http://trac.webkit.org/changeset/200054>
Comment 5 WebKit Commit Bot 2016-04-25 15:40:25 PDT 
All reviewed patches have been landed.  Closing bug.