Bug 156979

Summary: Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 156844    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2016-04-25 08:04:18 PDT 
Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow
Comment 1 youenn fablet 2016-04-25 08:07:31 PDT 
Created attachment 277249 [details]
Patch
Comment 2 Chris Dumez 2016-04-25 10:44:10 PDT 
Comment on attachment 277249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277249&action=review

r=me with comment.

> Source/WebCore/dom/WebKitNamedFlow.idl:38
> +    NodeList getRegionsByContent(Node? contentNode);

Should add a FIXME comment as I don't believe this matches the spec.
Comment 3 youenn fablet 2016-04-26 05:15:00 PDT 
Created attachment 277357 [details]
Patch for landing
Comment 4 youenn fablet 2016-04-26 05:16:25 PDT 
Thanks for the review.

> > Source/WebCore/dom/WebKitNamedFlow.idl:38
> > +    NodeList getRegionsByContent(Node? contentNode);
> 
> Should add a FIXME comment as I don't believe this matches the spec.

Right, I did not find the spec yesterday but found it now.
Patch is fixed accordingly
Comment 5 WebKit Commit Bot 2016-04-26 06:17:00 PDT 
Comment on attachment 277357 [details]
Patch for landing

Clearing flags on attachment: 277357

Committed r200079: <http://trac.webkit.org/changeset/200079>
Comment 6 WebKit Commit Bot 2016-04-26 06:17:04 PDT 
All reviewed patches have been landed.  Closing bug.