Bug 156979

Summary: Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 156844    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-04-25 08:04:18 PDT
Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow
Attachments
Patch (1.59 KB, patch)
2016-04-25 08:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.53 KB, patch)
2016-04-26 05:15 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-04-25 08:07:31 PDT
Created attachment 277249 [details] Patch
Chris Dumez
Comment 2 2016-04-25 10:44:10 PDT
Comment on attachment 277249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277249&action=review r=me with comment. > Source/WebCore/dom/WebKitNamedFlow.idl:38 > + NodeList getRegionsByContent(Node? contentNode); Should add a FIXME comment as I don't believe this matches the spec.
youenn fablet
Comment 3 2016-04-26 05:15:00 PDT
Created attachment 277357 [details] Patch for landing
youenn fablet
Comment 4 2016-04-26 05:16:25 PDT
Thanks for the review. > > Source/WebCore/dom/WebKitNamedFlow.idl:38 > > + NodeList getRegionsByContent(Node? contentNode); > > Should add a FIXME comment as I don't believe this matches the spec. Right, I did not find the spec yesterday but found it now. Patch is fixed accordingly
WebKit Commit Bot
Comment 5 2016-04-26 06:17:00 PDT
Comment on attachment 277357 [details] Patch for landing Clearing flags on attachment: 277357 Committed r200079: <http://trac.webkit.org/changeset/200079>
WebKit Commit Bot
Comment 6 2016-04-26 06:17:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.