Bug 156967

Summary: [Web IDL] Specify default values for parameters of type 'unsigned short'
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, darin, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-04-24 19:38:07 PDT
Specify default values for parameters of type 'unsigned short'
Attachments
Patch (8.46 KB, patch)
2016-04-24 19:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.14 KB, patch)
2016-04-25 10:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-04-24 19:41:51 PDT
Created attachment 277212 [details] Patch
Darin Adler
Comment 2 2016-04-24 22:13:05 PDT
Comment on attachment 277212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277212&action=review > Source/WebCore/testing/Internals.idl:229 > + [RaisesException] DOMString layerTreeAsText(Document document, optional unsigned short flags = 0); I don’t understand why the IDL says "unsigned short", but the implementation says "unsigned". These should be "unsigned long" instead. > Source/WebCore/testing/Internals.idl:244 > + [RaisesException] DOMString displayListForElement(Element element, optional unsigned short flags = 0); Ditto. > Source/WebCore/testing/Internals.idl:246 > + [RaisesException] DOMString replayDisplayListForElement(Element element, optional unsigned short flags = 0); Ditto.
Chris Dumez
Comment 3 2016-04-25 10:49:26 PDT
Created attachment 277260 [details] Patch
Chris Dumez
Comment 4 2016-04-25 11:38:30 PDT
Comment on attachment 277260 [details] Patch Clearing flags on attachment: 277260 Committed r200037: <http://trac.webkit.org/changeset/200037>
Chris Dumez
Comment 5 2016-04-25 11:38:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.