Summary: | Web Inspector: Can't sort by name/source code location columns in Timeline data grids | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Matt Baker
2016-04-24 17:54:35 PDT
Created attachment 277207 [details]
[Patch] Proposed Fix
Comment on attachment 277207 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=277207&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js:-304 > - let currentDataGridNode = this.children[0]; The children array here was not the DOM, it is DataGridNodes. You should revert this. Created attachment 277211 [details]
[Patch] Proposed Fix
Comment on attachment 277211 [details] [Patch] Proposed Fix Clearing flags on attachment: 277211 Committed r199974: <http://trac.webkit.org/changeset/199974> All reviewed patches have been landed. Closing bug. |