Bug 156965

Summary: Web Inspector: Can't sort by name/source code location columns in Timeline data grids
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Description Flags
[Patch] Proposed Fix
[Patch] Proposed Fix none

Description Matt Baker 2016-04-24 17:54:35 PDT
Can't sort by name/source code location columns in Timeline data grids. In the network and script (details) data grids, these columns contain document fragments and can't be sorted.

For "location" to work, TimelineDataGrid's sort comparer just needs a special case for SourceCodeLocation values. For the name column which can contain main title and subtitle text, add a delegate to TimelineDataGrid so that view's can override the sort comparer per-column, as needed.
Comment 1 Radar WebKit Bug Importer 2016-04-24 17:54:57 PDT
Comment 2 Matt Baker 2016-04-24 18:05:08 PDT
Created attachment 277207 [details]
[Patch] Proposed Fix
Comment 3 Timothy Hatcher 2016-04-24 18:39:25 PDT
Comment on attachment 277207 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=277207&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js:-304
> -        let currentDataGridNode = this.children[0];

The children array here was not the DOM, it is DataGridNodes. You should revert this.
Comment 4 Matt Baker 2016-04-24 19:01:45 PDT
Created attachment 277211 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2016-04-24 20:08:55 PDT
Comment on attachment 277211 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 277211

Committed r199974: <http://trac.webkit.org/changeset/199974>
Comment 6 WebKit Commit Bot 2016-04-24 20:08:59 PDT
All reviewed patches have been landed.  Closing bug.