Bug 156960

Summary: Web Inspector: Error when selecting a bar in the Frames timeline
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 154924    
Bug Blocks: 156963    
Description Flags
[Patch] Proposed Fix none

Description Matt Baker 2016-04-24 14:41:40 PDT
Error when selecting a bar in the Frames timeline. Inspector dies with: undefined is not an object (evaluating 'this.currentTimelineView.navigationSidebarTreeOutline.selectedTreeElement').

The fault lies with TimelineRecordingContentView._recordSelected, which assumes all TimelineViews have a tree outline.
Comment 1 Radar WebKit Bug Importer 2016-04-24 14:41:54 PDT
Comment 2 Matt Baker 2016-04-24 14:43:43 PDT
A fix is ready. Waiting on https://webkit.org/b/154924, which adds grid support to TimelineView.
Comment 3 Matt Baker 2016-04-24 16:04:05 PDT
Created attachment 277200 [details]
[Patch] Proposed Fix
Comment 4 Matt Baker 2016-04-24 16:10:00 PDT
This patch prevents the crash but there is another problem with record selection: https://bugs.webkit.org/show_bug.cgi?id=156963
Comment 5 WebKit Commit Bot 2016-04-24 18:02:58 PDT
Comment on attachment 277200 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 277200

Committed r199972: <http://trac.webkit.org/changeset/199972>
Comment 6 WebKit Commit Bot 2016-04-24 18:03:02 PDT
All reviewed patches have been landed.  Closing bug.