Bug 156951

Summary: [Win] Plugin stream temporary file is deleted too early.
Product: WebKit Reporter: peavo
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: achristensen, beidson, bfulgham, dbates, ddkilzer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch beidson: review-

peavo
Reported 2016-04-23 03:03:16 PDT
The plugin stream temporary file is currently deleted in PluginStream::destroyStream(). This is too early for some plugins, since they appear to be trying to read this file after m_pluginFuncs->asfile() has been called. The file will then be deleted, and the plugin will fail to read it. We can instead delete the temporary file in the plugin stream destructor.
Attachments
Patch (2.21 KB, patch)
2016-04-23 03:28 PDT, peavo 		beidson: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2016-04-23 03:28:16 PDT
Created attachment 277146 [details] Patch
Darin Adler
Comment 2 2016-04-23 16:43:36 PDT
Comment on attachment 277146 [details] Patch It’s normally not a good pattern to do any externally visible work that is based on reference counting. It’s very easy to accidentally change the timing. We have worked hard to not do this kind of work in the destructors in most cases. Is there some other time that’s appropriate other than destruction of the stream object?
Brady Eidson
Comment 3 2017-08-19 16:01:20 PDT
Comment on attachment 277146 [details] Patch r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form.
Brent Fulgham
Comment 4 2022-07-01 10:38:36 PDT
NPAPI plugins have been removed.
Note You need to log in before you can comment on or make changes to this bug.