Bug 156927

Summary:

Web Inspector: Include columnNumber in event listener locations

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2016-04-22 13:49:08 PDT

* SUMMARY Include columnNumber in event listener locations. This is needed in minified code to jump to accurate locations.

Attachments
[PATCH] Proposed Fix (2.25 KB, patch) 2016-04-22 13:54 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-04-22 13:49:31 PDT

<rdar://problem/25884584>

Joseph Pecoraro

Comment 2 2016-04-22 13:54:14 PDT

Created attachment 277096 [details] [PATCH] Proposed Fix

Blaze Burg

Comment 3 2016-04-22 14:11:58 PDT

Comment on attachment 277096 [details] [PATCH] Proposed Fix No test coverage? :(

Blaze Burg

Comment 4 2016-04-22 16:52:55 PDT

Comment on attachment 277096 [details] [PATCH] Proposed Fix r=me This is a reminder to file a bug somewhere about adding test coverage for event listener locations.

WebKit Commit Bot

Comment 5 2016-04-22 17:44:24 PDT

Comment on attachment 277096 [details] [PATCH] Proposed Fix Clearing flags on attachment: 277096 Committed r199940: <http://trac.webkit.org/changeset/199940>

WebKit Commit Bot

Comment 6 2016-04-22 17:44:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.