Summary: | Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, cdumez, commit-queue, darin, eric.carlson, esprehn+autocc, gyuyoung.kim, kondapallykalyan, philipj | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 156844 | ||||||||
Attachments: |
|
Description
youenn fablet
2016-04-22 02:17:48 PDT
Created attachment 277028 [details]
Patch
Comment on attachment 277028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277028&action=review r=me with nit > Source/WebCore/html/track/TextTrack.idl:43 > readonly attribute TextTrackCueList cues; Since we are passing by, could we mark this one as nullable to match the spec (no behavior change) > Source/WebCore/html/track/TextTrack.idl:44 > readonly attribute TextTrackCueList activeCues; Since we are passing by, could we mark this one as nullable to match the spec (no behavior change) (In reply to comment #2) > Comment on attachment 277028 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277028&action=review > > r=me with nit > > > Source/WebCore/html/track/TextTrack.idl:43 > > readonly attribute TextTrackCueList cues; > > Since we are passing by, could we mark this one as nullable to match the > spec (no behavior change) > > > Source/WebCore/html/track/TextTrack.idl:44 > > readonly attribute TextTrackCueList activeCues; > > Since we are passing by, could we mark this one as nullable to match the > spec (no behavior change) Thanks for the review. I'll check this and update patch accordingly. Created attachment 277238 [details]
Patch for landing
Comment on attachment 277238 [details] Patch for landing Clearing flags on attachment: 277238 Committed r199986: <http://trac.webkit.org/changeset/199986> All reviewed patches have been landed. Closing bug. |