Bug 156899

Summary:

Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, cdumez, commit-queue, darin, eric.carlson, esprehn+autocc, gyuyoung.kim, kondapallykalyan, philipj

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

156844

Attachments:

Description	Flags
Patch	none
Patch for landing	none

youenn fablet

Reported 2016-04-22 02:17:48 PDT

Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack.

Attachments
Patch (2.32 KB, patch) 2016-04-22 02:20 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (2.50 KB, patch) 2016-04-25 02:25 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2016-04-22 02:20:28 PDT

Created attachment 277028 [details] Patch

Chris Dumez

Comment 2 2016-04-22 09:46:55 PDT

Comment on attachment 277028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277028&action=review r=me with nit > Source/WebCore/html/track/TextTrack.idl:43 > readonly attribute TextTrackCueList cues; Since we are passing by, could we mark this one as nullable to match the spec (no behavior change) > Source/WebCore/html/track/TextTrack.idl:44 > readonly attribute TextTrackCueList activeCues; Since we are passing by, could we mark this one as nullable to match the spec (no behavior change)

youenn fablet

Comment 3 2016-04-24 04:52:37 PDT

(In reply to comment #2) > Comment on attachment 277028 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277028&action=review > > r=me with nit > > > Source/WebCore/html/track/TextTrack.idl:43 > > readonly attribute TextTrackCueList cues; > > Since we are passing by, could we mark this one as nullable to match the > spec (no behavior change) > > > Source/WebCore/html/track/TextTrack.idl:44 > > readonly attribute TextTrackCueList activeCues; > > Since we are passing by, could we mark this one as nullable to match the > spec (no behavior change) Thanks for the review. I'll check this and update patch accordingly.

youenn fablet

Comment 4 2016-04-25 02:25:55 PDT

Created attachment 277238 [details] Patch for landing

WebKit Commit Bot

Comment 5 2016-04-25 03:26:28 PDT

Comment on attachment 277238 [details] Patch for landing Clearing flags on attachment: 277238 Committed r199986: <http://trac.webkit.org/changeset/199986>

WebKit Commit Bot

Comment 6 2016-04-25 03:26:35 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.