Bug 15689

Summary: [GTK] Background of loading images is always black
Product: WebKit Reporter: Alp Toker <alp>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor Keywords: Cairo, Gtk
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Fix
none
Simplified fix mrowe: review+

Alp Toker
Reported 2007-10-25 08:32:17 PDT
The background of currently loading images is always black. This is kind of distracting. It should be transparent, or at least similar to the background of the page.
Attachments
Fix (2.88 KB, patch)
2007-11-28 04:20 PST, Alp Toker 		no flags
DetailsFormatted DiffDiff
Simplified fix (2.76 KB, patch)
2007-11-28 04:30 PST, Alp Toker 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alp Toker
Comment 1 2007-11-28 01:23:23 PST
This can be fixed by returning true in all cases in ImageSource::frameHasAlphaAtIndex() in ImageSourceCairo.cpp. A better fix would preserve the optimization. I'm working on a solution now.
Alp Toker
Comment 2 2007-11-28 04:20:08 PST
Created attachment 17573 [details] Fix Includes a workaround for http://bugs.webkit.org/show_bug.cgi?id=16169
Alp Toker
Comment 3 2007-11-28 04:30:18 PST
Created attachment 17574 [details] Simplified fix
Mark Rowe (bdash)
Comment 4 2007-11-28 04:36:55 PST
Comment on attachment 17574 [details] Simplified fix r=me
Alp Toker
Comment 5 2007-11-28 04:48:14 PST
Landed in r28109.
Note You need to log in before you can comment on or make changes to this bug.