Bug 15689

Summary:

[GTK] Background of loading images is always black

Product:

WebKit

Reporter:

Alp Toker <alp>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

Keywords:

Cairo, Gtk

Priority:

Version:

523.x (Safari 3)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Fix	none
Simplified fix	mrowe: review+

Description Alp Toker 2007-10-25 08:32:17 PDT

The background of currently loading images is always black. This is kind of distracting. It should be transparent, or at least similar to the background of the page.

Comment 1 Alp Toker 2007-11-28 01:23:23 PST

This can be fixed by returning true in all cases in ImageSource::frameHasAlphaAtIndex() in ImageSourceCairo.cpp.

A better fix would preserve the optimization. I'm working on a solution now.

Comment 2 Alp Toker 2007-11-28 04:20:08 PST

Created attachment 17573 [details]
Fix

Includes a workaround for http://bugs.webkit.org/show_bug.cgi?id=16169

Comment 3 Alp Toker 2007-11-28 04:30:18 PST

Created attachment 17574 [details]
Simplified fix

Comment 4 Mark Rowe (bdash) 2007-11-28 04:36:55 PST

Comment on attachment 17574 [details]
Simplified fix

r=me

Comment 5 Alp Toker 2007-11-28 04:48:14 PST

Landed in r28109.