Bug 15689 - [GTK] Background of loading images is always black
Summary: [GTK] Background of loading images is always black
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords: Cairo, Gtk
Depends on:
Blocks:
 
Reported: 2007-10-25 08:32 PDT by Alp Toker
Modified: 2007-11-28 04:48 PST (History)
0 users

See Also:


Attachments
Fix (2.88 KB, patch)
2007-11-28 04:20 PST, Alp Toker
no flags Details | Formatted Diff | Diff
Simplified fix (2.76 KB, patch)
2007-11-28 04:30 PST, Alp Toker
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-10-25 08:32:17 PDT
The background of currently loading images is always black. This is kind of distracting. It should be transparent, or at least similar to the background of the page.
Comment 1 Alp Toker 2007-11-28 01:23:23 PST
This can be fixed by returning true in all cases in ImageSource::frameHasAlphaAtIndex() in ImageSourceCairo.cpp.

A better fix would preserve the optimization. I'm working on a solution now.
Comment 2 Alp Toker 2007-11-28 04:20:08 PST
Created attachment 17573 [details]
Fix

Includes a workaround for http://bugs.webkit.org/show_bug.cgi?id=16169
Comment 3 Alp Toker 2007-11-28 04:30:18 PST
Created attachment 17574 [details]
Simplified fix
Comment 4 Mark Rowe (bdash) 2007-11-28 04:36:55 PST
Comment on attachment 17574 [details]
Simplified fix

r=me
Comment 5 Alp Toker 2007-11-28 04:48:14 PST
Landed in r28109.