Bug 156878

Summary:

RenderVideo should always update the intrinsic size before layout.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adachan, commit-queue, dbates, jeremyj-wk, jer.noble, jonlee, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2016-04-21 16:23:24 PDT

and definitely not after that.

Comment 1 zalan 2016-04-21 16:33:52 PDT

Created attachment 276980 [details]
Patch

Comment 2 WebKit Commit Bot 2016-04-21 18:13:13 PDT

Comment on attachment 276980 [details]
Patch

Clearing flags on attachment: 276980

Committed r199856: <http://trac.webkit.org/changeset/199856>

Comment 3 WebKit Commit Bot 2016-04-21 18:13:17 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Daniel Bates 2016-04-28 00:47:20 PDT

Comment on attachment 276980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276980&action=review

> Source/WebCore/rendering/RenderVideo.cpp:225
> +    bool intrinsicSizeChanged;
> +    intrinsicSizeChanged = updateIntrinsicSize();

I would have written this in one line:

bool intrinsicSizeChanged = updateIntrinsicSize();