Bug 156878

Summary: RenderVideo should always update the intrinsic size before layout.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: adachan, commit-queue, dbates, jeremyj-wk, jer.noble, jonlee, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

zalan
Reported 2016-04-21 16:23:24 PDT
and definitely not after that.
Attachments
Patch (3.27 KB, patch)
2016-04-21 16:33 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2016-04-21 16:33:52 PDT
Created attachment 276980 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-21 18:13:13 PDT
Comment on attachment 276980 [details] Patch Clearing flags on attachment: 276980 Committed r199856: <http://trac.webkit.org/changeset/199856>
WebKit Commit Bot
Comment 3 2016-04-21 18:13:17 PDT
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 4 2016-04-28 00:47:20 PDT
Comment on attachment 276980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276980&action=review > Source/WebCore/rendering/RenderVideo.cpp:225 > + bool intrinsicSizeChanged; > + intrinsicSizeChanged = updateIntrinsicSize(); I would have written this in one line: bool intrinsicSizeChanged = updateIntrinsicSize();
Note You need to log in before you can comment on or make changes to this bug.