Bug 156861

Summary:

Stop using ApplicationCacheStorage::singleton() on Windows

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	darin: review+

Description Anders Carlsson 2016-04-21 13:02:47 PDT

Stop using ApplicationCacheStorage::singleton() on Windows

Comment 1 Anders Carlsson 2016-04-21 13:06:49 PDT

Created attachment 276945 [details]
Patch

Comment 2 Anders Carlsson 2016-04-21 13:36:11 PDT

Created attachment 276952 [details]
Patch

Comment 3 Darin Adler 2016-04-21 13:46:08 PDT

Comment on attachment 276952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276952&action=review

> Source/WebKit/win/WebApplicationCache.cpp:66
> +    RetainPtr<CFPropertyListRef> cacheDirectoryPreference = adoptCF(CFPreferencesCopyAppValue(WebKitLocalCacheDefaultsKey, kCFPreferencesCurrentApplication));

Use auto here?

> Source/WebKit/win/WebApplicationCache.cpp:67
> +    if (cacheDirectoryPreference && (CFStringGetTypeID() == CFGetTypeID(cacheDirectoryPreference.get())))

Remove extra () here?

Comment 4 Anders Carlsson 2016-04-21 14:16:41 PDT

Committed r199836: <http://trac.webkit.org/changeset/199836>