Summary: | Stop using ApplicationCacheStorage::singleton() on Windows | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Anders Carlsson
2016-04-21 13:02:47 PDT
Created attachment 276945 [details]
Patch
Created attachment 276952 [details]
Patch
Comment on attachment 276952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276952&action=review > Source/WebKit/win/WebApplicationCache.cpp:66 > + RetainPtr<CFPropertyListRef> cacheDirectoryPreference = adoptCF(CFPreferencesCopyAppValue(WebKitLocalCacheDefaultsKey, kCFPreferencesCurrentApplication)); Use auto here? > Source/WebKit/win/WebApplicationCache.cpp:67 > + if (cacheDirectoryPreference && (CFStringGetTypeID() == CFGetTypeID(cacheDirectoryPreference.get()))) Remove extra () here? Committed r199836: <http://trac.webkit.org/changeset/199836> |