Bug 156856 – AX: Media controls are operable but not visible after returning from Full Screen Mode

• Component: Accessibility
• Status: NEW

[Aaron Chu]

Created attachment 276940 [details]
an analysis of the makeup for the media controls.

Test case: http://ghbweb.com/ios_video_issue/

As a correct behavior, the media controls disappear at about 3 ~ 4 seconds after the play button is clicked. When a user starts a video and enter full screen, the controls (or the container anyway) remains in the DOM for about 3 ~ 4 before it disappears. When the user exists full screen mode, the controls return as operable invisible controls. Attached please see an analysis of the markup for the controls. It appears that "-webkit-media-controls-panel-background" and "-webkit-media-controls-panel" are missing the "show" class after the user exists full screen.

[Radar WebKit Bug Importer]

<rdar://problem/25858658>

[Aaron Chu]

Created attachment 278396 [details]
Patch

[Aaron Chu]

Comment on attachment 278396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278396&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:-527
> -            this.showShowControlsButton(false);

moving this outside because it it not tied to the if-clause just as the base Controller.

[chris fleizach]

Comment on attachment 278396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278396&action=review

> Source/WebCore/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).

can you add a comment regarding how this was fixed

> ChangeLog:9
> +        * ManualTests/ios/video-cotnrols-to-show-on-inline-mode-from-fullscreen-button.html: Added.

is there anyway to make this an automated test

cotnrols spelled wrong

> ManualTests/ios/video-cotnrols-to-show-on-inline-mode-from-fullscreen-button.html:8
> +<p>This test can be used to verify that after exiting Full Screen mode using the "Full Screen" button, the inline video controls is shown and the "showControlButton" is hidden.</p>

... controls "are" shown...