Bug 156854

Summary: [WK1] Add WebPlaybackSession support to WebKit
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: NEW    
Severity: Normal CC: bdakin, commit-queue, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bdakin: review+
Patch for landing none

Jer Noble
Reported 2016-04-21 10:58:09 PDT
[WK1] Add WebPlaybackSession support to WebKit
Attachments
Patch (8.20 KB, patch)
2016-04-21 11:01 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (8.24 KB, patch)
2016-04-21 11:05 PDT, Jer Noble 		bdakin: review+
DetailsFormatted DiffDiff
Patch for landing (8.56 KB, patch)
2016-04-21 15:38 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-04-21 11:01:37 PDT
Created attachment 276936 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-21 11:02:29 PDT
Attachment 276936 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebView.mm:8575: The parameter name "!" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 3 2016-04-21 11:05:39 PDT
Created attachment 276937 [details] Patch
WebKit Commit Bot
Comment 4 2016-04-21 11:07:42 PDT
Attachment 276937 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebView.mm:8576: The parameter name "!" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 5 2016-04-21 14:06:28 PDT
Comment on attachment 276937 [details] Patch r=me, but definitely take a look at those red bots
Jer Noble
Comment 6 2016-04-21 15:38:48 PDT
Created attachment 276972 [details] Patch for landing
WebKit Commit Bot
Comment 7 2016-04-21 15:49:44 PDT
Attachment 276972 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebView.mm:8557: The parameter name "!" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 8 2016-04-21 16:55:44 PDT
Comment on attachment 276972 [details] Patch for landing Clearing flags on attachment: 276972 Committed r199846: <http://trac.webkit.org/changeset/199846>
Jon Lee
Comment 9 2016-04-22 16:43:04 PDT
rdar://problem/24866862
Note You need to log in before you can comment on or make changes to this bug.