Summary: | [GTK][EFL] Move non-glib/gtk platform implementations out of platform/gtk | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> | ||||||
Component: | New Bugs | Assignee: | Claudio Saavedra <csaavedra> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, mrobinson | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 157027 | ||||||||
Attachments: |
|
Description
Claudio Saavedra
2016-04-21 06:14:16 PDT
Created attachment 276916 [details]
Patch
Attachment 276916 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/unix/LanguageUnix.cpp:25: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 276916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276916&action=review > Source/WebCore/PlatformGTK.cmake:187 > + > + platform/unix/LanguageUnix.cpp > + platform/unix/LoggingUnix.cpp You should do the same for EFL, since the implementation is now the same, no? > Source/WebCore/platform/unix/LanguageUnix.cpp:25 > + Remove this empty line here. > Source/WebCore/platform/unix/LanguageUnix.cpp:49 > + Vector<String> userPreferredLanguages; > + userPreferredLanguages.append(platformLanguage()); > + return userPreferredLanguages; This could just be return { platformLanguage() }; I think > Source/WebCore/platform/unix/LoggingUnix.cpp:46 > + String logLevel = "NotYetImplemented,"; > + logLevel.append(logEnv); > + return logLevel; And this could probably be return String("NotYetImplemented,") + logEnv Created attachment 276922 [details]
Patch for landing
Comment on attachment 276922 [details] Patch for landing Clearing flags on attachment: 276922 Committed r199815: <http://trac.webkit.org/changeset/199815> All reviewed patches have been landed. Closing bug. *** Bug 116460 has been marked as a duplicate of this bug. *** |