Bug 156833

Summary: Build fail because of quotes.
Product: WebKit Reporter: Ryan Rafe Lee <holo>
Component: WebCore Misc.Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Minor CC: achristensen, annulen, commit-queue, fujii.hironori, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch
none
Patch
none
Patch none

Ryan Rafe Lee
Reported 2016-04-20 22:00:26 PDT
Build fails when upstream version string has some special letter. Because cmake automatically insert quotes when build. At Source/WebCore/CMakeList.txt, there's code setting PYTHONPATH variable. When version has some special letter like '2.10.4+dev12~1.gbp7c2f8b' builds fail with error '/bin/sh: 1: PYTHONPATH=/tmp/buildd/webkit2gtk-2.10.4+dev12~1.gbp7c2f8b/Source/JavaScriptCore/inspector/scripts: not found'. Because command will be 'cd "/tmp/buildd/webkit2gtk-2.10.4+dev12~1.gbp7c2f8b/obj-i586-linux-gnu/Source/WebCore" && "PYTHONPATH=/tmp/buildd/webkit2gtk-2.10.4+dev12~1.gbp7c2f8b/Source/JavaScriptCore/inspector/scripts" /usr/bin/python2.7 ...' ps. I changed format 3.0(quilt) to 3.0(native). Because I don't need quilt.
Attachments
patch (1.53 KB, patch)
2016-04-20 22:01 PDT, Ryan Rafe Lee 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2016-04-26 00:24 PDT, Ryan Rafe Lee 		no flags
DetailsFormatted DiffDiff
Patch (1.69 KB, patch)
2017-02-16 04:28 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryan Rafe Lee
Comment 1 2016-04-20 22:01:18 PDT
Created attachment 276899 [details] patch
Alex Christensen
Comment 2 2016-04-25 11:09:16 PDT
The env command doesn't exist on Windows.
Ryan Rafe Lee
Comment 3 2016-04-26 00:24:22 PDT
Created attachment 277347 [details] Patch Use -E for platform independence. But '-E env' depends on cmake>=3.1.
Alex Christensen
Comment 4 2016-04-26 10:25:43 PDT
Comment on attachment 277347 [details] Patch We currently support CMake 2.8.12, and I don't think this alone is reason enough to bump the minimum version that high.
Konstantin Tokarev
Comment 5 2017-02-16 04:28:14 PST
Created attachment 301743 [details] Patch
WebKit Commit Bot
Comment 6 2017-02-16 09:12:46 PST
Comment on attachment 301743 [details] Patch Clearing flags on attachment: 301743 Committed r212435: <http://trac.webkit.org/changeset/212435>
WebKit Commit Bot
Comment 7 2017-02-16 09:12:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.