Summary: | Build fail because of quotes. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Rafe Lee <holo> | ||||||||
Component: | WebCore Misc. | Assignee: | Konstantin Tokarev <annulen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Minor | CC: | achristensen, annulen, commit-queue, Hironori.Fujii, mcatanzaro | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Ryan Rafe Lee
2016-04-20 22:00:26 PDT
Created attachment 276899 [details]
patch
The env command doesn't exist on Windows. Created attachment 277347 [details]
Patch
Use -E for platform independence. But '-E env' depends on cmake>=3.1.
Comment on attachment 277347 [details]
Patch
We currently support CMake 2.8.12, and I don't think this alone is reason enough to bump the minimum version that high.
Created attachment 301743 [details]
Patch
Comment on attachment 301743 [details] Patch Clearing flags on attachment: 301743 Committed r212435: <http://trac.webkit.org/changeset/212435> All reviewed patches have been landed. Closing bug. |