Bug 156830

Summary: DFG del_by_id support forgets to set()
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch saam: review+

Filip Pizlo
Reported 2016-04-20 19:12:36 PDT
Patch forthcoming.
Attachments
the patch (2.66 KB, patch)
2016-04-20 19:17 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (1.99 KB, patch)
2016-04-20 19:20 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-04-20 19:17:37 PDT
Created attachment 276885 [details] the patch
WebKit Commit Bot
Comment 2 2016-04-20 19:19:11 PDT
Attachment 276885 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4244: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2016-04-20 19:20:06 PDT
(In reply to comment #2) > Attachment 276885 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4244: One line > control clauses should not use braces. [whitespace/braces] [4] > Total errors found: 1 in 3 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Oops, I'll remove that.
Filip Pizlo
Comment 4 2016-04-20 19:20:26 PDT
Created attachment 276886 [details] the patch
Filip Pizlo
Comment 5 2016-04-20 19:35:30 PDT
Landed in http://trac.webkit.org/changeset/199801
Note You need to log in before you can comment on or make changes to this bug.