Bug 156819

Summary: AX: stringForTextMarkerRange returning empty string for document range
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Initial patch
none
patch none

Nan Wang
Reported 2016-04-20 16:36:16 PDT
Text markers created from visible positions might have PositionIsAfterAnchor anchor type, so CharacterOffset will be anchored to a different node. <rdar://problem/25793161>
Attachments
Initial patch (5.43 KB, patch)
2016-04-20 17:15 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (5.40 KB, patch)
2016-04-20 17:30 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-20 16:36:40 PDT
<rdar://problem/25842260>
Nan Wang
Comment 2 2016-04-20 17:15:11 PDT
Created attachment 276872 [details] Initial patch
chris fleizach
Comment 3 2016-04-20 17:22:10 PDT
Comment on attachment 276872 [details] Initial patch View in context: https://bugs.webkit.org/attachment.cgi?id=276872&action=review > Source/WebCore/ChangeLog:9 > + or PositionIsAfterChildren anchor type. So that the character offset corresponds to the anchored this "nchor type. So that t" should be "nchor type, so that t > Source/WebCore/accessibility/AXObjectCache.cpp:1974 > + // convert to character offset this line seems superfluous > Source/WebCore/accessibility/AXObjectCache.cpp:1975 > + // If the visible position has anchor type referring to node other than the anchored node, we should has "an" anchor type referring to "a" node
Nan Wang
Comment 4 2016-04-20 17:30:35 PDT
Created attachment 276875 [details] patch review comments
WebKit Commit Bot
Comment 5 2016-04-21 01:40:56 PDT
Comment on attachment 276875 [details] patch Clearing flags on attachment: 276875 Committed r199809: <http://trac.webkit.org/changeset/199809>
WebKit Commit Bot
Comment 6 2016-04-21 01:41:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.