Summary: | AX: stringForTextMarkerRange returning empty string for document range | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nan Wang <n_wang> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Nan Wang
2016-04-20 16:36:16 PDT
Created attachment 276872 [details]
Initial patch
Comment on attachment 276872 [details] Initial patch View in context: https://bugs.webkit.org/attachment.cgi?id=276872&action=review > Source/WebCore/ChangeLog:9 > + or PositionIsAfterChildren anchor type. So that the character offset corresponds to the anchored this "nchor type. So that t" should be "nchor type, so that t > Source/WebCore/accessibility/AXObjectCache.cpp:1974 > + // convert to character offset this line seems superfluous > Source/WebCore/accessibility/AXObjectCache.cpp:1975 > + // If the visible position has anchor type referring to node other than the anchored node, we should has "an" anchor type referring to "a" node Created attachment 276875 [details]
patch
review comments
Comment on attachment 276875 [details] patch Clearing flags on attachment: 276875 Committed r199809: <http://trac.webkit.org/changeset/199809> All reviewed patches have been landed. Closing bug. |