Bug 156816

Summary: Enable heap separation on X86_64
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: NEW    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Oliver Hunt
Reported 2016-04-20 15:21:57 PDT
Enable heap separation on X86_64
Attachments
Patch (7.99 KB, patch)
2016-04-20 15:25 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (8.07 KB, patch)
2016-04-20 16:18 PDT, Oliver Hunt 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2016-04-20 15:25:39 PDT
Created attachment 276858 [details] Patch
Mark Lam
Comment 2 2016-04-20 15:41:30 PDT
Comment on attachment 276858 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276858&action=review r=me with comments. > Source/JavaScriptCore/assembler/X86Assembler.h:2776 > + performJITMemcpy(ptr, buffer, 1 + sizeof(int32_t)); As an idiom, can we use "sizeof(buffer)" instead of "1 + sizeof(int32_t)"? I would think it'd be less error prone to cut and paste errors this way. Ditto for all the sizes passed to performJITMemcpy below where appropriate.
Oliver Hunt
Comment 3 2016-04-20 16:12:52 PDT
I thought perf numbers were ok, but i think i ran the wrong builds, and am now getting too much variance. Also need to fix efl+ios sim
Oliver Hunt
Comment 4 2016-04-20 16:18:00 PDT
Created attachment 276863 [details] Patch
Mark Lam
Comment 5 2016-04-20 16:21:06 PDT
Comment on attachment 276863 [details] Patch r=me if the bots are happy.
Note You need to log in before you can comment on or make changes to this bug.