| Summary: | showCandidates() should take a range and the string should be the whole paragraph | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bdakin, commit-queue, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Beth Dakin
2016-04-20 14:58:56 PDT
Created attachment 276860 [details]
Patch
Attachment 276860 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2164: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1161: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1192: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 3 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 276861 [details]
Patch
Attachment 276861 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2164: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1161: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1192: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 3 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thanks Tim! http://trac.webkit.org/changeset/199828 |